Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expirations on huge values #4297

Closed
wants to merge 1 commit into from
+1 −1
Closed

fix: expirations on huge values #4297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/db_slice.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ OpResult<DbSlice::PrimeItAndExp> DbSlice::FindInternal(const Context& cntx, std:
}

if (res.it->second.HasExpire()) { // check expiry state
res = ExpireIfNeeded(cntx, res.it, true);
res = ExpireIfNeeded(cntx, res.it, false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we call FindInternal we always hold the lock to the key, or at least we should, if not its probably a bug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes and I think I am wrong here as well. There is something else that is happening.

if (!IsValid(res.it)) {
return OpStatus::KEY_NOTFOUND;
}
Expand Down
Loading