Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rdb_saver): Add SnapshotDataConsumer to SliceSnapshot #4287

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(rdb_saver): Add SnapshotDataConsumer to SliceSnapshot #4287

wants to merge 2 commits into from

Conversation

BagritsevichStepan
Copy link
Contributor

@BagritsevichStepan BagritsevichStepan commented Dec 11, 2024 •
edited
Loading

fixes #4218

  1. Move the two lambdas in SliceSnapshot to the SnapshotDataConsumerInterface.
  2. Apply minor syntax fixes in the RdbSaver class.

Also, it makes sense to store the Context* pointer directly within the RdbSaver class instead of passing it to methods like StartSnapshotInShard, StartIncrementalSnapshotInShard, and SaveBody

@BagritsevichStepan BagritsevichStepan self-assigned this Dec 11, 2024
chakaz
chakaz reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@chakaz chakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LG, please see a few nits

src/server/rdb_save.cc Show resolved Hide resolved
src/server/snapshot.cc Show resolved Hide resolved
src/server/snapshot.h Outdated Show resolved Hide resolved
src/server/snapshot.h Outdated Show resolved Hide resolved
@BagritsevichStepan
refactor: address comments
47116b6 
Signed-off-by: Stepan Bagritsevich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romange romange romange left review comments

@chakaz chakaz chakaz approved these changes

Assignees

@BagritsevichStepan BagritsevichStepan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replication small refactor
3 participants
@BagritsevichStepan @romange @chakaz