fix(search_family): Support multiple fields in SORTBY option in the FT.AGGREGATE command. SECOND PR #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GATE command fixes dragonflydb#4230 Signed-off-by: Stepan Bagritsevich <[email protected]>
…T.AGGREGATE command fixes dragonfly#3631 Signed-off-by: Stepan Bagritsevich <[email protected]>
BorysTheDev
reviewed
Nov 30, 2024
| @@ -11,10 +11,10 @@ namespace dfly::aggregate { | |||
| namespace { | |||
|
|
|||
| struct GroupStep { | |||
| PipelineResult operator()(std::vector<DocValues> values) { | |||
| PipelineResult operator()(PipelineResult result) { | |||
There was a problem hiding this comment.
PipelineResult contains more than result.values but you use only this field, maybe you don't need to change the type of parameter
BorysTheDev
reviewed
Nov 30, 2024
| absl::flat_hash_set<std::string> fields_to_print; | ||
| }; | ||
|
|
||
| using PipelineStep = std::function<PipelineResult(PipelineResult)>; // Group, Sort, etc. |
There was a problem hiding this comment.
Consider modifying current values instead of doing move
BorysTheDev
reviewed
Nov 30, 2024
| /* Fields to sort by. If multiple fields are provided, sorting works hierarchically: | ||
| - First, the i-th field is compared. | ||
| - If the i-th field values are equal, the (i + 1)-th field is compared, and so on. */ | ||
| absl::InlinedVector<std::pair<std::string, SortOrder>, 1> fields; |
There was a problem hiding this comment.
I would suggest using a bigger default capacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3631
Second PR for complete support of the SORTBY option. Please review first #4231