feat(codeql): Adds codeql action #4034
Conversation
|
Hello @BLANKatGITHUB ! Are you planning to work on this PR? |
|
I think the workflow is failing because the default codeql is on this repo for advanced codeql using workflow it should have been disabled. |
|
You can accept this pr by disabling the default codeql or close this pr and keep using the default codeql, it depends on you. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
hmm, it passed |
tests/codeql/build.sh
Outdated
| autoconf-archive libtool cmake g++ libzstd-dev bison libxml2-dev | ||
|
|
||
| # Clone the Dragonfly repository | ||
| git clone --recursive https://github.com/dragonflydb/dragonfly && cd dragonfly |
There was a problem hiding this comment.
why do you need to clone the directory? does not it defeat the purpose of checking a PR?
seems that steps
https://github.com/dragonflydb/dragonfly/pull/4034/files#diff-12783128521e452af0cfac94b99b8d250413c516ec71fe6d97dbea666ff7ba27R32-R33
should suffice
|
@BLANKatGITHUB thanks. Gave a comment. see ci.yml for example. And then use the checked out repo to build the finary. |
Signed-off-by: Blanky <[email protected]>
Signed-off-by: Blanky <[email protected]>
Signed-off-by: Blanky <[email protected]>
|
It looks good now. |
|
I think the code is fine now |
Adds codeql action to build the project from scratch and perform code anaylsis for security vulnerabilities.
Fixes #4033