Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replication small refactor #4218

Open
adiholden opened this issue Nov 28, 2024 · 0 comments · May be fixed by #4287
Open

Replication small refactor #4218

adiholden opened this issue Nov 28, 2024 · 0 comments · May be fixed by #4287
Assignees
@BagritsevichStepan
Labels
replication Related to replication logic

Comments

@adiholden
Copy link
Collaborator

Following this comment
#4041 (comment)

Instead of passing 2 lamda functions to SliceSnapshot use virtual interface for Push and Finalize
@adiholden adiholden added the replication Related to replication logic label Nov 28, 2024
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Dec 11, 2024
@BagritsevichStepan
refactor(rdb_saver): Add SnapshotDataConsumer to SliceSnapshot
2005e9d 
fixes dragonflydb#4218

Signed-off-by: Stepan Bagritsevich <[email protected]>
@BagritsevichStepan BagritsevichStepan linked a pull request Dec 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BagritsevichStepan BagritsevichStepan

Labels
replication Related to replication logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(rdb_saver): Add SnapshotDataConsumer to SliceSnapshot BagritsevichStepan/dragonfly
2 participants
@BagritsevichStepan @adiholden