Skip to content

Commit

Permalink
reproduce list bug
Browse files Browse the repository at this point in the history
  • Loading branch information
kostasrim committed Dec 12, 2024
1 parent cd845ee commit 7e14eeb
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
24 changes: 12 additions & 12 deletions tests/dragonfly/replication_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,19 @@ async def wait_for_replicas_state(*clients, state="online", node_role="slave", t
@pytest.mark.parametrize(
"t_master, t_replicas, seeder_config, stream_target",
[
# Quick general test that replication is working
(1, 3 * [1], dict(key_target=1_000), 500),
# A lot of huge values
# # Quick general test that replication is working
# (1, 3 * [1], dict(key_target=1_000), 500),
# # A lot of huge values
(2, 2 * [1], dict(key_target=1_000, huge_value_percentage=2), 500),
(4, [4, 4], dict(key_target=10_000), 1_000),
pytest.param(6, [6, 6, 6], dict(key_target=100_000), 20_000, marks=M_OPT),
# Skewed tests with different thread ratio
pytest.param(8, 6 * [1], dict(key_target=5_000), 2_000, marks=M_SLOW),
pytest.param(2, [8, 8], dict(key_target=10_000), 2_000, marks=M_SLOW),
# Everything is big because data size is 10k
pytest.param(2, [2], dict(key_target=1_000, data_size=10_000), 100, marks=M_SLOW),
# Stress test
pytest.param(8, [8, 8], dict(key_target=1_000_000, units=16), 50_000, marks=M_STRESS),
# (4, [4, 4], dict(key_target=10_000), 1_000),
# pytest.param(6, [6, 6, 6], dict(key_target=100_000), 20_000, marks=M_OPT),
# # Skewed tests with different thread ratio
# pytest.param(8, 6 * [1], dict(key_target=5_000), 2_000, marks=M_SLOW),
# pytest.param(2, [8, 8], dict(key_target=10_000), 2_000, marks=M_SLOW),
# # Everything is big because data size is 10k
# pytest.param(2, [2], dict(key_target=1_000, data_size=10_000), 100, marks=M_SLOW),
# # Stress test
# pytest.param(8, [8, 8], dict(key_target=1_000_000, units=16), 50_000, marks=M_STRESS),
],
)
@pytest.mark.parametrize("mode", [({}), ({"cache_mode": "true"})])
Expand Down
2 changes: 1 addition & 1 deletion tests/dragonfly/seeder/script-genlib.lua
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function LG_funcs.add_list(key, keys)
local is_huge = keys[key]
--- TODO -- investigate why second case of replication_test_all fails
--- we somehow create a quicklist that is circular and we deadlock
redis.apcall('LPUSH', key, unpack(randstr_sequence(false)))
redis.apcall('LPUSH', key, unpack(randstr_sequence(is_huge)))
end

function LG_funcs.mod_list(key, keys)
Expand Down

0 comments on commit 7e14eeb

Please sign in to comment.