-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does the hessian really gets computed? #59
Comments
I also noticed this; I tried setting
|
zou3519
added a commit
to zou3519/benchmark
that referenced
this issue
Sep 21, 2022
Fixes pytorch#328 Here's some context: - We discovered that the implementation doesn't actually use maml (dragen1860/MAML-Pytorch#59) - We filed pytorch#328 - We added maml_omniglot pytorch#349 as the correct version of of the maml model. - We didn't delete the maml model (because I was worried that it was doing a "different" type of maml that I hadn't seen before that is still valid). The last step to resolve this issue is to delete the incorrect MAML example, unless we have reasons to keep it around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I find that for the inner loop update, the gradients are being computed without keeping the create_graph=True, this means that the hessian was not essentially applied?
The text was updated successfully, but these errors were encountered: