From 57f52cc116e9a47f06e9daa67cd98d7fb9f050d8 Mon Sep 17 00:00:00 2001
From: Leo Q <LeoQuote@users.noreply.github.com>
Date: Sat, 20 Feb 2021 18:41:01 +0800
Subject: [PATCH] use image.tag instead of appversion (#5)

* use image.tag instead of appversion

* Update deployment.yaml

* bump version and delete appVersion

* add appVersion and home

* Update Chart.yaml
---
 charts/nginx/Chart.yaml                | 11 ++++++-----
 charts/nginx/templates/deployment.yaml |  2 +-
 charts/nginx/values.yaml               |  1 +
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/charts/nginx/Chart.yaml b/charts/nginx/Chart.yaml
index 092d1ec..8119f10 100644
--- a/charts/nginx/Chart.yaml
+++ b/charts/nginx/Chart.yaml
@@ -1,7 +1,9 @@
 apiVersion: v2
 name: nginx
+home: https://nginx.org/
 description: A Helm chart for Kubernetes
-
+maintainers:
+- name: douban
 # A chart can be either an 'application' or a 'library' chart.
 #
 # Application charts are a collection of templates that can be packaged into versioned archives
@@ -14,8 +16,7 @@ type: application
 
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 0.1.1
+version: 0.1.2
 
-# This is the version number of the application being deployed. This version number should be
-# incremented each time you make changes to the application.
-appVersion: 1.16.0
+# This is actually not used.
+appVersion: 0.16.0
diff --git a/charts/nginx/templates/deployment.yaml b/charts/nginx/templates/deployment.yaml
index a29e019..a33f6d8 100644
--- a/charts/nginx/templates/deployment.yaml
+++ b/charts/nginx/templates/deployment.yaml
@@ -25,7 +25,7 @@ spec:
         - name: {{ .Chart.Name }}
           securityContext:
             {{- toYaml .Values.securityContext | nindent 12 }}
-          image: "{{ .Values.image.repository }}:{{ .Chart.AppVersion }}"
+          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           ports:
             - name: http
diff --git a/charts/nginx/values.yaml b/charts/nginx/values.yaml
index c52d321..64a289f 100644
--- a/charts/nginx/values.yaml
+++ b/charts/nginx/values.yaml
@@ -6,6 +6,7 @@ replicaCount: 1
 
 image:
   repository: nginx
+  tag: 0.16.0
   pullPolicy: IfNotPresent
 
 imagePullSecrets: []