Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Static Web Assets] Fix duplicate endpoints when resolving referenced asset endpoints #41995

Merged
merged 2 commits into from
Jul 8, 2024
Merged

[Static Web Assets] Fix duplicate endpoints when resolving referenced asset endpoints #41995

merged 2 commits into from
Jul 8, 2024

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Jul 5, 2024

  • We were using the wrong itemgroup and that was causing additional endpoints to be added by mistake.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Jul 5, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @javiercn.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@javiercn javiercn mentioned this pull request Jul 5, 2024
Closed
@javiercn javiercn requested a review from a team as a code owner July 5, 2024 21:19
@javiercn javiercn mentioned this pull request Jul 8, 2024
Merged
@javiercn javiercn enabled auto-merge (squash) July 8, 2024 14:11
@javiercn javiercn force-pushed the javiercn/fix-duplicate-endpoints-update-assets branch from 78b06a1 to 945c7ec Compare July 8, 2024 14:11
@build-analysis build-analysis bot mentioned this pull request Jul 8, 2024
Open
3 tasks
@javiercn javiercn merged commit 0e34227 into main Jul 8, 2024
37 checks passed
@javiercn javiercn deleted the javiercn/fix-duplicate-endpoints-update-assets branch July 8, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@MackinnonBuck MackinnonBuck Awaiting requested review from MackinnonBuck

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javiercn @halter73