Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic dependency update PRs should include version information #5489

Open
lbussell opened this issue May 22, 2024 · 3 comments
Open

Automatic dependency update PRs should include version information #5489

lbussell opened this issue May 22, 2024 · 3 comments

Comments

@lbussell
Copy link
Contributor

We should consider adding the SDK build number to automatic dependency update PRs in this repo.

This would provide a few benefits:

  • easier to evaluate the correctness of dependency flow PRs at a glance
  • there won't be tons of commits in the history that all have the same commit message
  • easier to trace back changes to specific .NET versions without diving into the diffs (for example, if an update needed to have a workaround added)
@lbussell
Copy link
Contributor Author

[Triage] One downside to changing the title is that it breaks email grouping for team members who use email notifications. Putting the version in the body would fix this, but then we wouldn't get to see the build version in the commit history.

@lbussell
Copy link
Contributor Author

[Triage] Another thing to consider is how the bot would need to update the title of the PR when it's force updated.

Seeing as this work would be non-trivial, it is probably not a good ROI at the moment.

@lbussell lbussell closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
@lbussell
Copy link
Contributor Author

[Triage] Another option would be to

  1. Change the default squash-merge commit message at a repo level to include the PR description in the commit message.
  2. Update the dependency update PR logic to include the version info in the PR description.

This would allow us some more visibility into dependency update commits as well as not break email chains.

@lbussell lbussell reopened this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant