Allow dynamic localization of command display name and descriptions #6984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is not currently possible for resource commands to contain localizations for their display name, description, or confirmation message. This is problematic because the rest of the dashboard is localized depending on the client's current display locale.
I changed the associated properties of
ResourceCommandSnapshot
andResourceCommandAnnotation
to functions that will produce a display string based on context (currently only locale).I added localized display names and descriptions for the resources that we add (stop/start/restart).
I also added another method in
ResourceBuilderExtensions
,ResourceBuilderExtensions.WithLocalizedCommand
, in case it would be desired to keep theWithCommand
extension (because of the breaking change in arguments). Is there a different recommended approach?We do not need to modify the dashboard client in any way other than passing the current display locale, as the page is reloaded on locale change.
As this is a draft, I am especially looking for suggestions about design or naming.
Fixes #6982
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template): waiting on doc updates until at least the design is revieweddoc-idea
template):Microsoft Reviewers: Open in CodeFlow