Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Net7 Support and Microsoft.Data.SqlClient #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mehdihaghshenas
Copy link

No description provided.

@ErikEJ
Copy link

ErikEJ commented Nov 13, 2022

Have you tried the latest rc release of the official Microsoft.SqlServet.Types ??

@mehdihaghshenas
Copy link
Author

Yes I test it on EFCore.SqlServer.HierarchyId and everything is OK

@mehdihaghshenas
Copy link
Author

Have you tried the latest rc release of the official Microsoft.SqlServet.Types ??

why Microsoft does not add these projects to EF Core official yet?

@ErikEJ
Copy link

ErikEJ commented Nov 13, 2022

Because they are not used by EF Core.

Copy link
Owner

@dotMorten dotMorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of unrelated changes. Also please add a description what this is supposed to achieve.

@mehdihaghshenas
Copy link
Author

I just update version and fixed errors

@dotMorten
Copy link
Owner

I still don’t know what issue you’re fixing here. I still see white space changes and new usings defined with no code changes otherwise. I see you add net7 but no description why and other package versions also changed for some reason.

@mehdihaghshenas
Copy link
Author

I still don’t know what issue you’re fixing here. I still see white space changes and new usings defined with no code changes otherwise. I see you add net7 but no description why and other package versions also changed for some reason.

Your package has conflicted with dot net 7.0.0

@dotMorten
Copy link
Owner

What do you mean conflicted? What sort of errors are you seeing? Net7 should be compatible with net6 packages.

@mehdihaghshenas
Copy link
Author

What do you mean conflicted? What sort of errors are you seeing? Net7 should be compatible with net6 packages.
during update of https://github.com/efcore/EFCore.SqlServer.HierarchyId I have runtime error because of that your package use Microsoft.Data.SqlClient v4.0 and then I update your package
I'm finally use official Microsoft.SqlServet.Types rc that support .NET Standard

@dotMorten
Copy link
Owner

I'm finally use official Microsoft.SqlServet.Types rc that support .NET Standard

You don’t need this package if you’re using the official one. That would naturally clash. This entire project is soon no longer needed as the official package is finally doing what this project set out to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants