Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to get a page from URL, not only the title and pageId #56

Open
carlmachaalani opened this issue Jan 10, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@carlmachaalani
Copy link

carlmachaalani commented Jan 10, 2024

Hi,

It would be nice to also add the URL of the Wikipedia page as a parameter of wiki.page(), not only the title and pageId.

Thanks!

@carlmachaalani carlmachaalani changed the title Ability to get a page from URL, not just topic name Ability to get a page from URL, not only the title and pageId Jan 10, 2024
@dopecodez
Copy link
Owner

Any suggestions on what would be the better approach - wiki.page("https://en.wikipedia.org/wiki/Batman") or more explicitly having wiki.page(url: "https://en.wikipedia.org/wiki/Batman").
It sounds like an useful feature that would be worth exploring.

@dopecodez dopecodez added the enhancement New feature or request label Jan 13, 2024
@carlmachaalani
Copy link
Author

Thanks for your reply.

In my opinion, explicitly having wiki.page(url: "https://en.wikipedia.org/wiki/Batman") would be cleaner.

@kingram6865
Copy link

Thanks for your reply.

In my opinion, explicitly having wiki.page(url: "https://en.wikipedia.org/wiki/Batman") would be cleaner.

I agree. Explicitly indicating url is a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants