Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution to the Longest Common Subsequence needs corrections #209

Open
Code-ScottLe opened this issue Aug 30, 2017 · 1 comment
Open

Solution to the Longest Common Subsequence needs corrections #209

Code-ScottLe opened this issue Aug 30, 2017 · 1 comment
Labels
needs-review

Comments

@Code-ScottLe
Copy link

Code-ScottLe commented Aug 30, 2017 •
edited
Loading

The current solution could be spooked with 2 inputs : "ABCDFE" and "FOOBCDBCDE". The logic will create a map that will still end up having the last letter E in sequence.

According to Wikipedia , they are filling in 0 instead of taking the max (left, above) for characters that aren't matched.
@sumuksr2
Copy link

Hi! My name is Sumuk and I'm interested in working on this open source project and I hope to start by working on this issue. Please let me know how I can get started and what I will need to read to begin on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@donnemartin @Code-ScottLe @sumuksr2