Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bst_valid_challenge's one test case is wrong #197

Open
goalong opened this issue May 30, 2017 · 3 comments
Open

bst_valid_challenge's one test case is wrong #197

goalong opened this issue May 30, 2017 · 3 comments
Labels

Comments

@goalong
Copy link
Contributor

goalong commented May 30, 2017

hi, I noticed that test case below is not a valid binary search tree, it might be valid if we delete the node 6, but in your challenge notebook marked it as valid. I'm not sure I should delete the node 6 and send a pr or just submit an issue, so I just submit an issue.
Valid:

      5
    /   \
   5     8
  / \   /
 4   6 7
@donnemartin
Copy link
Owner

Hi @goalong, nice catch! Yes I think we should delete node 6 in the test cases and unit tests.

Are you interested in a PR?

@goalong
Copy link
Contributor Author

goalong commented May 31, 2017

Sure, I will send a PR soon.

@girishkumbhar
Copy link

Ok, Send PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants