Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort count output. #189

Open
TaylanUB opened this issue Nov 16, 2017 · 3 comments · May be fixed by #249
Open

Sort count output. #189

TaylanUB opened this issue Nov 16, 2017 · 3 comments · May be fixed by #249

Comments

@TaylanUB
Copy link

IMO this should be standard behavior. Achieving it is extremely easy: In helper.php, add ksort($otags) before returning $otags.

(I'm in a rush so I don't have time to fork and make a pull request, sorry.)

@tmo26
Copy link

tmo26 commented May 2, 2018

Confirmed working on Greebo.
Wonderful easy solution, implemented in 1 minute.
Thanks for sharing your findings!

Now this only needs to be implemented in master...

proxymus added a commit to proxymus/plugin-tag that referenced this issue Oct 16, 2018
@espiegel123
Copy link

Please do implement sorting the list alphabetically!

@tmo26
Copy link

tmo26 commented Apr 20, 2022

Changing return $otags; -> return ksort($otags); in helper.php does not seem to work any more with Release 2020-07-29 "Hogfather" / PHP 7.4.25

Result after changing helper.php accordingly: Empty list
grafik

Solution: Add a separate line for the ksort, instead of including it in the return statement:

        ksort($otags);
        return $otags;

@proxymus If you can confirm this, your patch should be updated accordingly.

Klap-in added a commit that referenced this issue Aug 19, 2023
@Klap-in Klap-in linked a pull request Oct 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants