Add integration test for unexpected output #406
Assignees
Labels
Comments
stepanstipl
added a commit
that referenced
this issue
Dec 1, 2022
This PR disables warnings from go-client. Unfortunately this is not sufficient to also supress the warning about deprecated auth plugins, therefore the need for klog output code too. But in general direct logging from 3rd-party libs is undesirable, and this configures K8S's go-client klog to discard any logs. I've added some tests to cover some unexpected 3rd-party output, but as this depends on the environment and kubeconfig config, incl. providers, and is noteasily reproducible, this should be covered by integration test, as the current test do not fully cover this. Opened #406. fixes #402
stepanstipl
added a commit
that referenced
this issue
Dec 2, 2022
This PR disables warnings from go-client. Unfortunately this is not sufficient to also supress the warning about deprecated auth plugins, therefore the need for klog output code too. But in general direct logging from 3rd-party libs is undesirable, and this configures K8S's go-client klog to discard any logs. I've added some tests to cover some unexpected 3rd-party output, but as this depends on the environment and kubeconfig config, incl. providers, and is noteasily reproducible, this should be covered by integration test, as the current test do not fully cover this. Opened #406. fixes #402
stepanstipl
added a commit
that referenced
this issue
Dec 7, 2022
This PR disables warnings from go-client. Unfortunately this is not sufficient to also supress the warning about deprecated auth plugins, therefore the need for klog output code too. But in general direct logging from 3rd-party libs is undesirable, and this configures K8S's go-client klog to discard any logs. I've added some tests to cover some unexpected 3rd-party output, but as this depends on the environment and kubeconfig config, incl. providers, and is noteasily reproducible, this should be covered by integration test, as the current test do not fully cover this. Opened #406. fixes #402
stepanstipl
added a commit
that referenced
this issue
Dec 7, 2022
This PR disables warnings from go-client. Unfortunately this is not sufficient to also supress the warning about deprecated auth plugins, therefore the need for klog output code too. But in general direct logging from 3rd-party libs is undesirable, and this configures K8S's go-client klog to discard any logs. I've added some tests to cover some unexpected 3rd-party output, but as this depends on the environment and kubeconfig config, incl. providers, and is noteasily reproducible, this should be covered by integration test, as the current test do not fully cover this. Opened #406. fixes #402
stepanstipl
added a commit
that referenced
this issue
Dec 8, 2022
This PR disables warnings from go-client. Unfortunately this is not sufficient to also supress the warning about deprecated auth plugins, therefore the need for klog output code too. But in general direct logging from 3rd-party libs is undesirable, and this configures K8S's go-client klog to discard any logs. I've added some tests to cover some unexpected 3rd-party output, but as this depends on the environment and kubeconfig config, incl. providers, and is noteasily reproducible, this should be covered by integration test, as the current test do not fully cover this. Opened #406. fixes #402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As PR for #402 is not fully tested (and not possible/feasible to test with unit tests), we should cover unexpected output with integration tests.
The text was updated successfully, but these errors were encountered: