-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mermaid 🧜♀️ to Markdown parser #4168
Comments
Include diagrams in your Markdown files with Mermaid
graph TD;
A-->B;
A-->C;
B-->D;
C-->D;
|
We are dependant on our markdown parser for this. Currently, kramdown has no support for mermaid. It seems like the gitlab fork supports it, but other things might break. For example, math support is lacking there. |
Hi @heremansgeert |
@heremansgeert We have a pr to introduce this, but this introduces quite a lot new javascript dependencies, which also means a lot of maintenance in the future. Could you give us an indication of how important this feature is to you, so we can make a better decision on whether we want to roll it out? @BTWS2, @RobbeW, @deepeebee do any of you have an opinion on this? As you are some of our larger content creators, it would be good to know if you would be using mermaid when it is available in Dodona. |
It seems nice to have, but I don't have that many use cases for it. Exporting to an image and adding it in Markdown doesn't seem such a hassle to me. A flow chart doesn't change that often I think, so adding the Mermaid code to the existing GitHub repo and exporting to an image seems fine to me. If you export to an image you have more control of the exact lay-out I think, but I don't have experience with Mermaid. |
Hi, If my opinion would change, I feel capable to export to an image and include that in the markdown. So I agree with the 'nice to have but not of increased relevance for me'. I'll check with my colleague for his opinion on the matter. |
@jorg-vr Thanks for taking a look at this. But I consider this nice to have but not crucial. Introducing a lot of dependencies just for this feature is probably not worth the effort. As @RobbeW mentioned, I primarily used flowcharts for the first exercises and don't add them to my descriptions later on. Regarding the feedback about uploading an image, since this is only a small effort: This is of course true. Uploading an image and including it in the description is only a small effort. However... I like to include as much information in my exercise repositories in markdown syntax. I prefer to generate resources from the markdown if at all possible. I include a file called feedback.md in my evaluation directory. In there I store the feedback I give to students when they take a test (I've been using Dodona before stored feedback was available). Although I love the new feature to store the feedback, personally, I would love that this could be pulled from the repository. So when I re-use an exercise next year, the feedback is already available. The same can be said about evaluation (scores). I am now starting with an HTML course after giving Docusaurus a try. One of the features I liked in Docusaurus is that you can use a Browserwindow component. It allows rendering HTML for markdown. For example, this code:
Would be rendered like this: One can say it's easy to take a screenshot from the rendered HTML code, but I hope you'll see that there is a benefit from generating this from the Markdown. |
Thanks everyone for the responses. Based on your feedback, we'll close this issue and the related pr as a won't fix. @heremansgeert I'll respond to your other notes
Being able to reuse feedback across courses and exercises is on our radar. See #4993
I'll take this into account when working on #4940
We already support this, without the need for the |
@heremansgeert I would advise against using an HTML-render to show the desired result for an HTML-exercise. This way the solution is only two clicks away (Rightclick, Inspect or View page source). I use images for the render for this reason (and consistent lay-out). |
@BTWS2 That is unfortunately true for exercises but could come in handy for reading activities. Again, scope is limited. |
When writing a description for an exercise, it would be great if we could include flowcharts generated by a Markdown'ish syntax.
Currently, I'm working with Visio and exporting it to images. By including the flowcharts in the markdown I can keep all information about an excersies centraly at one location in the repo.
Mermaid is a Javascript library lets you create diagrams and visualizations using text and code1.
Footnotes
Mermaid ↩
The text was updated successfully, but these errors were encountered: