-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing navbar with only coverpage #1696
Comments
@CxRes can you please provide a working reproduction? See the codesandbox link above. |
Wait, nvm, i see the second link. The first one pointed to the default sandbox. |
In your reproduction, there is no buttons on the cover page to go to any other page. I believe the expectation is that you will link to a page, then you will see a navbar on that page. Or no? Does this work on any other sites? If not, this may be a feature request. We could add an option to show navbar on cover-only pages (defaulting to false to be backward compatible). PRs welcome! |
@trusktr I added a button in the reproduction. There is no effect. This is not a feature request! It is a BUG!!! |
I'm not sure if this ever worked. I tried searching github for We should have this ability regardless if its a bug or not. |
pull request: #1706 (needs a test added for the feature) |
Confirmed working as expected on |
Bug Report
Steps to reproduce
loadnavbar: "_nav.md"
.onlyCover: true
What is current behaviour
The navbar is missing on first navigation to the page.
What is the expected behaviour
The navbar should exist unless set to false.
Other relevant information
If you go to an internal page and and
Bug does still occur when all/other plugins are disabled?
Your OS: Windows 10 x64
Node.js version: 14.17.5
npm/yarn version: 6.14.14
Browser version: Brave Version 1.33.106 Chromium: 96.0.4664.110 (Official Build) (64-bit)
Docsify version: 4.12.1
Docsify plugins: NA
Please create a reproducible sandbox
Sandbox link: https://codesandbox.io/s/elated-sound-6s1rq
Mention the docsify version in which this bug was not present (if any)
The text was updated successfully, but these errors were encountered: