Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Heading button section, in order to put a chat button in there #40

Open
Tracked by #43
HMarzban opened this issue Jan 23, 2023 · 2 comments
Open
Tracked by #43
Labels
Editor Tiptap & Prosemirror enhancement New feature or request

Comments

@HMarzban
Copy link
Collaborator

HMarzban commented Jan 23, 2023

There is a problem here, @edsaperia I need your help:

Image

Each heading contains two buttons right now:
1/ # for copying the id of the heading into the clipboard.
2/ A toggle button, which is for folding and unfolding the section

Where should I add a new button for the chat? How should these three buttons be arranged?

@HMarzban HMarzban converted this from a draft issue Jan 23, 2023
@edsaperia
Copy link
Contributor

edsaperia commented Jan 23, 2023

  1. Heading id should go into the address bar when you click on the heading in the table of contents. No need for a button to copy onto clipboard.

  2. Toggle button stays as it is, but should only be visible on hover (see Toggle icons visible on hover only #39)

  3. Chat icon should be to the right of the heading in the margin of the document. If there are no unread chats, it should be a chat bubble, if there are unread chats it should be a number in a circle.

image

Unread chats should also be shown in the table of contents in blue circles, similar to slack:

image

@edsaperia
Copy link
Contributor

note that the designs of the icons are approximate - the images above just indicate the locations of the buttons.

@HMarzban HMarzban added Editor Tiptap & Prosemirror enhancement New feature or request labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor Tiptap & Prosemirror enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants