-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slash in tag converted to hyphen #189
Comments
@aaronadamsCA This pattern is documented in the
|
Thank you! That is well hidden in plain sight. A clear note would be helpful; it probably makes sense to convert path separators to hyphens so tags are usable sans transformation, but it does violate expectations when pattern matching. |
Agree. I was thinking about it but it will be a breaking change unfortunately. With #176 switch we might consider to solve it as it involves a major update anyway. Keep you in touch. |
@aaronadamsCA Oh btw, just recall it was already an issue in the past: #56 (comment) |
Behaviour
Steps to reproduce this issue
tags: type=match,pattern=devcontainer/v(.*),group=1
.devcontainer/v1.0.0
.Expected behaviour
Docker image version is
1.0.0
.Actual behaviour
Directory separator
/
is transformed to a hyphen-
. This is unexpected and (I'm pretty sure) undocumented, so it should either be fixed or documented. Thanks!Configuration
The text was updated successfully, but these errors were encountered: