Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set horizontal alignment of popovers #289

Open
jrubenoff opened this issue Oct 19, 2016 · 1 comment
Open

Set horizontal alignment of popovers #289

jrubenoff opened this issue Oct 19, 2016 · 1 comment
Labels
est_5 hold

Comments

@jrubenoff
Copy link
Contributor

Outcome

This should be possible:

screen shot 2016-10-18 at 6 41 08 pm

Custom classes for each button (primary small and small), aligned to the right edge of the link.

Structure

Popovers should have options for...

  • Whether the popover is aligned to the horizontal left, right, or center of the object. (This will also dictate the caret's horizontal position. For top and bottom-aligned popovers only.)
  • The class(es) of the primary button. (Default: primary)
  • The class(es) of the secondary button (Default: "no class")

Also, we should remove delete_ from some classes (like popover_delete_confirmation_message to get rid of code smells.)
@ajb ajb self-assigned this Oct 19, 2016
ajb added a commit that referenced this issue Oct 26, 2016
@ajb
add more options to confirmation popovers...
8ebe966 
...rework the API a little bit, too.

cf #289

I didn't add the advanced positioning, since that would best be
addressed upstream in Bootstrap.
@ajb ajb mentioned this issue Oct 26, 2016
Merged
ajb added a commit that referenced this issue Oct 26, 2016
@ajb
add more options to confirmation popovers... (#291)
bdbf9ed 
...rework the API a little bit, too.

cf #289

I didn't add the advanced positioning, since that would best be
addressed upstream in Bootstrap.
@ajb ajb removed the todo_current label Oct 26, 2016
@ajb ajb removed their assignment Oct 26, 2016
@ajb ajb added est_5 hold and removed est_3 labels Oct 26, 2016
@ajb
Copy link
Contributor

ajb commented Oct 26, 2016

This is done, with the exception of the alignment, which would need to be addressed in Bootstrap. I've marked it as "hold".

I can suggest positioning workarounds on a case-by-case basis.

@jrubenoff jrubenoff changed the title More flexible popovers Set horizontal alignment of popovers Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
est_5 hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajb @jrubenoff