Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional formatting #40

Open
dnnrly opened this issue Oct 23, 2022 · 2 comments
Open

Additional formatting #40

dnnrly opened this issue Oct 23, 2022 · 2 comments
Labels
Hacktoberfest help wanted Extra attention is needed

Comments

@dnnrly
Copy link
Owner

dnnrly commented Oct 23, 2022

Is your feature request related to a problem? Please describe.

A lot of very good work has been done to add much better formatting.

Describe the solution you'd like

  • Increase line coverage in tests
  • Remove panic from root package
  • Maybe a Brucy-bonus use of visitor pattern for applying formatting
@dnnrly dnnrly added help wanted Extra attention is needed Hacktoberfest labels Jun 26, 2023
@Erfanm83
Copy link
Contributor

Hi @dnnrly,

I hope you're doing well! I'm interested in contributing to your project as part of Hacktoberfest and noticed the help wanted label on improving the formatting and UX using the lipgloss package.

I'd love to:

  • Increase test line coverage.
  • Remove the panic from the root package.
  • Implement a visitor pattern for flexible formatting.

Could you please assign this task to me? I’m confident I can add meaningful improvements to the project and follow the best practices you have in place.

Thanks,
Erfanm83

@dnnrly
Copy link
Owner Author

dnnrly commented Oct 23, 2024

Hi, there's no need to assign a task. Just raise a PR and we'll take it from there.

Thanks so much for your consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants