Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better reference formatting #34

Open
dnnrly opened this issue Oct 2, 2022 · 12 comments
Open

Better reference formatting #34

dnnrly opened this issue Oct 2, 2022 · 12 comments
Assignees
Labels
Hacktoberfest help wanted Extra attention is needed

Comments

@dnnrly
Copy link
Owner

dnnrly commented Oct 2, 2022

Is your feature request related to a problem? Please describe.

Formatting of the output in this tool is rather cumbersome. It would be great if we could use a modern CLI formatting library to do something better, perhaps using something like this:
https://github.com/charmbracelet/lipgloss

Describe the solution you'd like
Better control over the look and feel of the output. Perhaps some additional configuration to customise it for user needs.

@dnnrly dnnrly added help wanted Extra attention is needed Hacktoberfest labels Oct 2, 2022
@georgettica
Copy link
Contributor

@dnnrly could you assign me?
I will.tinker with it in the coming days and see if I can add some knobs like:

  • format options (json/yaml)
  • Golang template printing (similar to docker ps --format)

I will also fig deeper into lipgloss to see if it fits the bill

@georgettica
Copy link
Contributor

I think I understand what you mean by reference formatting (without looking at lipgloss too much)

I think I can whip up a PR and some pictures and I'll ping you here

@georgettica
Copy link
Contributor


To be clear, will start the effort after being assigned :/

@dnnrly
Copy link
Owner Author

dnnrly commented Oct 4, 2022

I don't typically assign issues as I've had problems with people not completing them before. But I've had some good quality PRs from you before so happy to.

@georgettica
Copy link
Contributor

❤️

@georgettica
Copy link
Contributor

created a PR to fix the make test, can extend it to be across the whole binaries used
#37

@georgettica
Copy link
Contributor

will take inspiration from https://github.com/aarol/goclean/blob/master/view.go, unless you have a better way of formatting

@dnnrly
Copy link
Owner Author

dnnrly commented Oct 5, 2022

will take inspiration from https://github.com/aarol/goclean/blob/master/view.go, unless you have a better way of formatting

Yes, this is exactly the sort of thing I was thinking.

@georgettica
Copy link
Contributor

so I spoke to a friend who is a UI/UX expert, but I might create the base for him before he shows up and cleans it up color/UX wise.

wanted to let you know I didn't forget it and found some minutes to work on it

@dnnrly
Copy link
Owner Author

dnnrly commented Oct 8, 2022

Nah, you're good. You've already done loads. Getting a designer involved is good. We need to focus on make it as easy and useful as possible.

@georgettica
Copy link
Contributor

yeah, but if I get him on it it'll look better and I will learn some design elements (which is always a good thing)

@georgettica
Copy link
Contributor

@dnnrly , this is the coloring I got to so far.

now each element can be updated individually.

also added a global state to allow for the width to be updated on the fly (using dates and not bool as I heard a talk about it a while ago (can be moved back to bool if you want)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants