Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outstanding PDK warnings #201

Open
djjudas21 opened this issue Aug 16, 2023 · 0 comments
Open

Outstanding PDK warnings #201

djjudas21 opened this issue Aug 16, 2023 · 0 comments

Comments

@djjudas21
Copy link
Owner

Originally posted by @cruelsmith in #199 (review)

FYI: There are still some PDK warnings that has not been fixed by me. See forexample https://github.com/djjudas21/puppet-freeradius/actions/runs/5879050878/job/15942322938?pr=199#step:4:16

I would recommend to add --fail-on-warnings to .puppet-lint.rc so that the CI fails when also warnings exist. This can be also be added with

Rakefile:
  linter_fail_on_warnings: true

into .sync.yaml to make it persistent on pdk updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant