Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 Compatible: registry s3 driver support radosgw #960

Closed
wants to merge 3 commits into from
Closed

s3 Compatible: registry s3 driver support radosgw #960

wants to merge 3 commits into from

Conversation

simpleshuai
Copy link

Now, registry s3 driver unsupport RadosGW.
The pull request #808 @lorieri aims to this issue. Regrettably, pull request #808 is not enough beacuse there are several amazon S3 REST API that registry used but RadosGW unsupport:

This pull request aims to fix S3 compatibility mentioned above, and this PR work with two PRs below

About test, if there is a RadosGW , set env below to run CI tests using RadosGW as storage

AWS_REGION=generic
AWS_ACCESS_KEY=xxxxx
AWS_SECRET_KEY=xxxxx
S3_BUCKET=xxxx
S3_ENTRYPOINT=xxxx

In my environment, I set env mentioned above using a RadosGW as storage , all the tests in registry/storage/driver/testsuites/testsuites.go passed

Signed-off-by: wangmingshuai [email protected]

@lorieri
Copy link

lorieri commented Sep 8, 2015

I added you as collaborator on my branch, you can apply your commits there.
If you prefer we can do the opposite, give me access to yours.

cheers,

@simpleshuai simpleshuai closed this Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants