s3 Compatible: registry s3 driver support radosgw #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, registry s3 driver unsupport RadosGW.
The pull request #808 @lorieri aims to this issue. Regrettably, pull request #808 is not enough beacuse there are several amazon S3 REST API that registry used but RadosGW unsupport:
This pull request aims to fix S3 compatibility mentioned above, and this PR work with two PRs below
About test, if there is a RadosGW , set env below to run CI tests using RadosGW as storage
AWS_REGION=generic
AWS_ACCESS_KEY=xxxxx
AWS_SECRET_KEY=xxxxx
S3_BUCKET=xxxx
S3_ENTRYPOINT=xxxx
In my environment, I set env mentioned above using a RadosGW as storage , all the tests in registry/storage/driver/testsuites/testsuites.go passed
Signed-off-by: wangmingshuai [email protected]