From cf96c2db55e8b5bc32aa947f260817f665949e59 Mon Sep 17 00:00:00 2001 From: Jinoh Kang Date: Sat, 16 Jan 2021 17:16:56 +0900 Subject: [PATCH] tests: Use direct values instead of raw SQL Supersedes #11. In order to prevent (-1) from being masked by BitField.get_prep_value and converted to 15 (0xf), the test code uses a direct SQL statement. Its implementation has a few peculiarities that may be undesirable: - It uses an Django internal API, the Field.column attribute. Granted, this package already uses a lot of internal APIs, and Field.column is highly unlikely to change. However, in general using less internal APIs is better for future compatibility. - Using low-level API misses a lot of code paths that could have been tested. - Neither db_table nor db_column is escaped. In case we later incorporate tests involving pathological SQL object identifiers, we have to further use quote_name, which is not exactly public API either. Instead, we use models.Value() with an explicit output_field, which still avoids BitField.get_prep_value and inserts the value directly. Further, directly assign to __dict__ so that the BitFieldCreator descriptor's __set__ method is bypassed and the value is assigned unchanged. --- bitfield/tests/tests.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/bitfield/tests/tests.py b/bitfield/tests/tests.py index cbedc33e..b5d44d12 100644 --- a/bitfield/tests/tests.py +++ b/bitfield/tests/tests.py @@ -2,7 +2,7 @@ import pickle -from django.db import connection, models +from django.db import models from django.db.models import F from django.test import TestCase @@ -155,11 +155,12 @@ def test_regression_1425(self): self.assertTrue(instance.flags.FLAG_2) self.assertTrue(instance.flags.FLAG_3) - cursor = connection.cursor() - flags_field = BitFieldTestModel._meta.get_field('flags') - flags_db_column = flags_field.db_column or flags_field.name - cursor.execute("INSERT INTO %s (%s) VALUES (-1)" % (BitFieldTestModel._meta.db_table, flags_db_column)) - # There should only be the one row we inserted through the cursor. + # Bypass BitField.to_python and insert (-1) directly. + instance = BitFieldTestModel() + instance.__dict__['flags'] = models.Value(-1, output_field=models.IntegerField()) + instance.save() + + # There should only be the one row we inserted with a direct value. instance = BitFieldTestModel.objects.get(flags=-1) self.assertTrue(instance.flags.FLAG_0) self.assertTrue(instance.flags.FLAG_1)