Attachment in embeds causing message.attachments to be empty

[cakedan]

This isn't really a serious issue, but it still can cause confusion for bot owners. Currently, if you create a message with an attachment, it'll show up in message.attachments, but if you use the attachment in an embed, the attachment disappears from message.attachments. If you take the same message with the attachment in the embed, then edit the embed away, the attachment re-appears in message.attachments. This can cause issues if the bot creates a message with an attachment in the embed, then edits it away to replace it with some content as it will just cause the message to show that attachment all of a sudden. There's only one way to tell if the embed is using an attachment and that's by checking image.proxy_url, thumbnail.proxy_url, and video.proxy_url (video, for future cases because why not) to see if they start with https://media.discordapp.net/attachments/.

Maybe the message should always have the attachment show up in message.attachments or at least some kind of reference to this slight issue in the documentation.

Message with an attachment used in an embed:

{
  "attachments": [],
  "author": {
    "avatar": "7c2306f9ce96ce9805584ef823f58648",
    "bot": true,
    "discriminator": "9555",
    "id": "439205512425504771",
    "username": "NotSoBot"
  },
  "channel_id": "560593330270896129",
  "content": "",
  "edited_timestamp": null,
  "embeds": [
    {
      "image": {
        "height": 1080,
        "proxy_url": "https://media.discordapp.net/attachments/560593330270896129/673014340789600275/lol.png",
        "url": "https://cdn.discordapp.com/attachments/560593330270896129/673014340789600275/lol.png",
        "width": 1920
      },
      "type": "rich"
    }
  ],
  "flags": 0,
  "guild_id": "178313653177548800",
  "id": "673014341188190219",
  "member": {
    "deaf": false,
    "guild_id": "178313653177548800",
    "hoisted_role": "178314191524855808",
    "joined_at": "2018-04-27T00:53:27.697Z",
    "mute": false,
    "nick": "Ellis Boyd 'Red' Redding",
    "premium_since": null,
    "roles": [
      "178313653177548800",
      "178314191524855808",
      "439234137023578123",
      "611549073547329546"
    ]
  },
  "mentions": [],
  "mention_channels": [],
  "mention_everyone": false,
  "mention_roles": [],
  "nonce": null,
  "pinned": false,
  "reactions": [],
  "timestamp": "2020-02-01T03:58:42.941Z",
  "tts": false,
  "type": 0
}

Editing the embed away changes it to:

{
  "attachments": [
    {
      "filename": "lol.png",
      "height": 1080,
      "id": "673014340789600275",
      "proxy_url": "https://media.discordapp.net/attachments/560593330270896129/673014340789600275/lol.png",
      "size": 46517,
      "url": "https://cdn.discordapp.com/attachments/560593330270896129/673014340789600275/lol.png",
      "width": 1920
    }
  ],
  "author": {
    "avatar": "7c2306f9ce96ce9805584ef823f58648",
    "bot": true,
    "discriminator": "9555",
    "id": "439205512425504771",
    "username": "NotSoBot"
  },
  "channel_id": "560593330270896129",
  "content": "",
  "edited_timestamp": "2020-02-01T03:58:53.473Z",
  "embeds": [],
  "flags": 0,
  "guild_id": "178313653177548800",
  "id": "673014341188190219",
  "member": {
    "deaf": false,
    "guild_id": "178313653177548800",
    "hoisted_role": "178314191524855808",
    "joined_at": "2018-04-27T00:53:27.697Z",
    "mute": false,
    "nick": "Ellis Boyd 'Red' Redding",
    "premium_since": null,
    "roles": [
      "178313653177548800",
      "178314191524855808",
      "439234137023578123",
      "611549073547329546"
    ]
  },
  "mentions": [],
  "mention_channels": [],
  "mention_everyone": false,
  "mention_roles": [],
  "nonce": null,
  "pinned": false,
  "reactions": [],
  "timestamp": "2020-02-01T03:58:42.941Z",
  "tts": false,
  "type": 0
}

[night]

I don't think we can render attachments in both embeds and attachments concurrently as that may be more confusing for api consumers. Perhaps we can delete the attachment if the embed is removed.

[cakedan]

Yeah, currently it's not reliable to check embed.image/thumbnail/video.proxy_url for https://media.discordapp.net/attachments/ (to see if the message has an attachment). An embed created with an image/thumbnail using an attachment url, for example https://cdn.discordapp.com/attachments/560593330270896129/673014340789600275/lol.png, will cause the proxy_url to use https://media.discordapp.net/attachments/.

[curiosbasant]

I'm having the same issue, when I attach a image with the embed, the image shows just fine in the embed, but there is no way to remove the attachment again from the embed. Please help!

[KoB-Kirito]

Having the same problem here. It's really awkward behavior.
Couldn't you add some flag to the embed to make it at least easier to check against?
Checking for domain isn't that consistent, with the domain change etc.

[JWhyFR]

Same issue here.
I can send an image within an Embed in a message, but when I try to edit the message and replace the Embed (new content/new image) , the previous image "switches" to a MessageAttachment, the new image appears in the Embed, and both images are displayed in the message.
Roughly the same problem as explained here : hxxps://stackoverflow.com/questions/63050380/how-do-i-edit-an-image-inside-an-embed-discord
Thanks.