Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add Transonic + {Pythran, Cython} #12

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ashwinvis
Copy link

@ashwinvis ashwinvis commented Dec 30, 2021

Fixes #9

Notes:

  1. Calling the setup function multiple times in a benchmark should be avoided
  2. Equation of state benchmark was easy to implement
  3. Isoneutral benchmark has some issues -- does not compile yet, despite workaround in ba03d48
  4. TODO: Turbulent kinetic energy benchmark

@ashwinvis ashwinvis marked this pull request as draft December 30, 2021 23:53
@ashwinvis
Copy link
Author

cc: @serge-sans-paille and @paugier if you are interested

@ashwinvis ashwinvis changed the title DRAFT: Add Transonic + Pythran DRAFT: Add Transonic + {Pythran, Cython} Jan 1, 2022
…_energy

Pythran stderr:
WARNING: Compilation error, trying hard to find its origin...
CRITICAL: You shall not pass!
E: integrate_tke.py:32:10 error: Invalid argument type for function call to , no overload found, tried:
isoneutral_diffusion_pre_64ae2fbfb04321d92f82433831349a7a_f0f3aef9981d2f876201da9bbb8ae39b.py:26:24: Cannot convert 'npy_intp *' to Python object
Pythran stderr:
WARNING: Compilation error, trying hard to find its origin...
CRITICAL: You shall not pass!
E: integrate_tke.py:18:14 error: Dimension mismatch when slicing
----
    z_index = np.arange(a.shape[2])[np.newaxis, np.newaxis, :]
              ^~~~ (o_0)
----
@dionhaefner
Copy link
Owner

dionhaefner commented Jan 17, 2022

👋 @ashwinvis, thanks for the implementation. This looks really high quality. I'm just curious: could you share your experience with running the benchmarks through Transonic so far?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Transonic to comparison
2 participants