Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto handle exceptions of crop region #14

Open
din14970 opened this issue Nov 20, 2020 · 0 comments
Open

Auto handle exceptions of crop region #14

din14970 opened this issue Nov 20, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@din14970
Copy link
Owner

It seems to me (x,y)min and (x,y)max can be turned into (x, y)1 and (x, y)2 as the order should not matter. Internally, xmin is then min(x1, x2). Additionally, out of bounds can be automatically dealt with (x or y > width or height --> x or y set to width or height) instead of throwing errors. In this way, the show cropped region button could be removed and included in the update preview button -> the crop region shows up in the image when the apply crop checkbox is on. Now with the two buttons it's a bit confusing how the preview is getting updated.

@din14970 din14970 added the enhancement New feature or request label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant