Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning updates #970

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Versioning updates #970

merged 12 commits into from
Dec 12, 2024

Conversation

SmittieC
Copy link
Collaborator

@SmittieC SmittieC commented Dec 10, 2024

Resolves #887
Resolves #957

Description

  • Shows a badge when changes are detected
  • Out of sync assistants will not be allowed to be versioned
  • The created_at timestamp for the working version is hidden in the versions table.

User Impact

See the description

Demo

demo

Docs

P.s. I noticed a small issue. We don't consider file diffs when checking assistant diffs. Will fix in a follow-up

@SmittieC SmittieC requested a review from snopoke December 10, 2024 12:04
@SmittieC SmittieC marked this pull request as ready for review December 10, 2024 12:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 81.03448% with 11 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/experiments/views/experiment.py 57.89% 8 Missing ⚠️
apps/assistants/views.py 0.00% 2 Missing ⚠️
apps/experiments/tables.py 50.00% 1 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

apps/experiments/models.py Outdated Show resolved Hide resolved
@SmittieC SmittieC requested a review from snopoke December 12, 2024 07:57
@SmittieC SmittieC merged commit 1ca393a into main Dec 12, 2024
8 checks passed
@SmittieC SmittieC deleted the cs/versioning_updates branch December 12, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning UI improvement Prevent creation of an assistant version if OCS is missing files
3 participants