Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HELPME: Refactor problematic methods #31930

Open
ctsims opened this issue Jul 22, 2022 · 0 comments
Open

HELPME: Refactor problematic methods #31930

ctsims opened this issue Jul 22, 2022 · 0 comments

Comments

@ctsims
Copy link
Member

ctsims commented Jul 22, 2022

Our static analysis tools have shown that although our overall code quality has been improving, we've stalled or regressed on the volume of really bad ('E' or 'F' grade) blocks of code.

image

I investigated the outputs specifically and as expected some of this code is in legacy custom reports or other areas of low-risk. However, a number of these blocks are just long-standing methods that have continued to grow over time into broad and complex scopes, and have been actively edited by multiple people over the last 6-12 months. These are a good value proposition for intentional re-factoring.

These blocks have been tagged in the codebase with a comment lead by HELPME. The radon static analysis tool can be used to determine whether a function still triggers an 'E' or 'F' grade

$ radon cc . --min=E --exclude=node_modules/*,staticfiles/*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant