Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CEP] Treat 409 responses from forwarders as duplicates and don't resend. #28777

Open
ctsims opened this issue Nov 12, 2020 · 0 comments
Open
Labels
CEP CommCare Enhancement Proposal

Comments

@ctsims
Copy link
Member

ctsims commented Nov 12, 2020

Abstract
Change repeaters to not retry HTTP 409 responses

Motivation
OpenFN+OpenHIM users wanted a way to differentiate between traffic that was sent and traffic they didn't forward due to internal preconditions. It's at least somewhat common for systems to respond to duplicates with an HTTP 409, meaning "I already have a record for this, and don't want a new one." We are also likely to implement a "What you are sending is already on the server, and I don't need it" 409 response on CloudWorks for different reasons, so it's well aligned for consistency.

Specification
When HQ receives a 409 response to a Form Forwarding POST, it should not try to resend the record. Whether it is treated as a success or a failure internally is an open question. I

Impact on users
No impact on front-end users. Allows backend / API users slightly more granularity in interacting with CommCare.

Impact on hosting
Introduces more complexity in the array of potential interactions HQ can have in the API layer, including encouraging a new

Backwards compatibility
It should be evaluated whether we are currently receiving 409 responses from real servers. Clayton can evaluate that.

@ctsims ctsims added the CEP CommCare Enhancement Proposal label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CEP CommCare Enhancement Proposal
Projects
None yet
Development

No branches or pull requests

1 participant