Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PNA environment and variable references #6366

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

nospame
Copy link
Contributor

@nospame nospame commented Aug 15, 2024

Removes the entire pna environment and references to it, as the servers it pointed to were no longer active and DNS records have been removed as part of https://dimagi.atlassian.net/browse/SAAS-15848

I am less confident about the changes to ansible tasks here, since there was a small chunk of code referencing PNA_SITE_HOST, unlike the removal of other environments that appears a bit more straightforward.

Environments Affected

Removes pna environment, var removal likely affects production.

Copy link
Contributor

@millerdev millerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this do something similar to #6359 since it is also removing a file in src/commcare_cloud/ansible/roles/nginx/vars/ like #6357 did?

@@ -17,14 +17,14 @@
tags: common

- name: ufw (firewall)
hosts: 'all_commcarehq:!proxy:!cas_proxy:!pna_proxy:!couchdb2_proxy:!reach_proxy'
hosts: 'all_commcarehq:!proxy:!cas_proxy:!couchdb2_proxy:!reach_proxy'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume cas_proxy is also obsolete. Same below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good call. I missed that on #6358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants