Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple form save code from async task #2800

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Aug 2, 2024

Summary

Refactors Form Save code to decouple it from SaveToDisk Task into a helper class. This is required so that we can potentially call the form save logic outside a async task

Safety Assurance

  • If the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Automated test coverage

We have an automated integration test on form submissions.

Safety story

  • It's a relatively straightforward code movement from SaveToDiskTask to FormSaveHelper without any changes in business logic.
  • Tested a form submission locally

@shubham1g5 shubham1g5 requested review from avazirna and ctsims August 2, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant