Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

og:site_name does not fallback to site title #36

Open
Maybach91 opened this issue Jul 28, 2021 · 2 comments
Open

og:site_name does not fallback to site title #36

Maybach91 opened this issue Jul 28, 2021 · 2 comments

Comments

@Maybach91
Copy link

According to the Inputfields Help’ it says the og:site_name open_graph.yml:82 property will fallback to the site name.

og_site_name:
    label: OG Site Name
    help: If your object is part of a larger web site, the name which should be displayed for the overall site. Will use *site title* as fallback.
    type: text
    width: 1/2

But in the meta_information.phpLine 82 i cannot see, that it will fallback to the title:

<meta property="og:site_name" content="<?= $page->og_site_name()->or($site->og_site_name()) ?>">

Is that intended?

@jonathanmuth
Copy link
Contributor

Thanks for pointing this out. The bug will be fixed in the next release.

@Maybach91
Copy link
Author

Yay, nice! Thank you so much @jonathanmuth :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants