Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applyEdit TASK_STATUS_CHANGE: do not set workerId #29

Open
nicoloboschi opened this issue Oct 30, 2017 · 0 comments
Open

applyEdit TASK_STATUS_CHANGE: do not set workerId #29

nicoloboschi opened this issue Oct 30, 2017 · 0 comments
Assignees

Comments

@nicoloboschi
Copy link
Contributor

JIRA: https://dev.majordodo.org/jira/browse/MAJ-97

Reporter: caio @CaioK

Signature of the StatusEdit initializer is:
{code}
public static final StatusEdit TASK_STATUS_CHANGE(long taskId, String workerId, int finalStatus, String result)
{code}

but in applyModifications workerId is not set.

We should add this set, maybe raising an exception if new workerId != null and is not equal to the current workerId (in fact, the only circumstance when this parameter could be useful is to reset task workerId to null, since the real set of workerId is done by ASSIGN_TASK_TO_WORKER).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants