mainmenu.cpp

[JoBergeron]

Why do we have two files named "mainmenu.cpp" ? It seems to be causing issues with Xcode when generating the corresponding .o files (it's also sort of unusual to have two files named the same within the same project)

[AJenbo]

originally DiabloUI and the application used to be two separate projects.

[AJenbo]

ingamemainmenu.cpp doesn't work as a name as it is not the ingame menu but the part that calls up the main menu and reacts to selections in it.

[JoBergeron]

I hadn't really looked at it's content to be honest. I was sort of guessing there.

Maybe have one called mainmenuimpl?

[AJenbo]

impl is that short for implementation?

I would rather just call it menu.cpp. The ingame one is called gamemenu/gmenu

[JoBergeron]

menu.cpp seems alright yeah

[AJenbo]

Ok, feel free to send the PR for that :)