Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change output of RISE to have a zero neutral value #784

Open
cwmeijer opened this issue Jun 5, 2024 · 2 comments
Open

change output of RISE to have a zero neutral value #784

cwmeijer opened this issue Jun 5, 2024 · 2 comments
Assignees
@cwmeijer

Comments

@cwmeijer
Copy link
Member

cwmeijer commented Jun 5, 2024

We should subtract p_keep from the output map before returning and mention this in the docstring.
@elboyran elboyran mentioned this issue Jun 5, 2024
Open
@elboyran
Copy link
Contributor

Is the best place to do that in the normalize function fromrise_utils?

@elboyran
Copy link
Contributor

Is this the solution to #856?

@elboyran elboyran mentioned this issue Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwmeijer cwmeijer

Labels
None yet
Projects
No open projects
Bugfixes, finish use cases, and outreach
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elboyran @cwmeijer