Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36
I have:
However I've spent already quite a long time with it so now I put it here so that someone can finish the work. There are TODOs in
AresV2
class - basically 3 of 4 methods have to be rewritten and the already rewritten method has some BC issues which I'm not able to solve on my own. Maybe @dfridrich can look into that BC issues.Resources:
h4kuna/ares
: Support new ARES2 API h4kuna/ares#31