Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump up canbench to 0.1.8 #347

Merged
merged 12 commits into from
Dec 10, 2024
Merged

chore: bump up canbench to 0.1.8 #347

merged 12 commits into from
Dec 10, 2024

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Dec 9, 2024

This PR upgrades canbench crate to v.0.1.8 and pocket-ic to 6.0.0.

Canbench tests for this PR showed a regression for pre_upgrade_with_many_unstable_blocks, but that is expected since in canbench v.0.1.5 there was a fix for correctly accounting the instructions when writing stable memory (release), which is exactly what is happening in bitcoin canister pre_upgrade.

Copy link

github-actions bot commented Dec 9, 2024

canbench 🏋 (dir: .)

Significant performance change detected! ⚠️

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 563.25 M (0.26%) (change within noise threshold)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.00 M (0.01%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (0.09%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.92 B (0.13%) (change within noise threshold)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: pre_upgrade_with_many_unstable_blocks
  total:
    instructions: 5.97 B (regressed by 2.70%)
    heap_increase: 4097 pages (no change)
    stable_memory_increase: 1792 pages (no change)

  serialize_blocktree (scope):
    instructions: 2.39 B (0.45%) (change within noise threshold)
    heap_increase: 2048 pages (no change)
    stable_memory_increase: 0 pages (no change)

  serialize_blocktree_flatten (scope):
    instructions: 201.60 K (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  serialize_blocktree_serialize_seq (scope):
    instructions: 2.39 B (0.45%) (change within noise threshold)
    heap_increase: 2048 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@maksymar maksymar changed the title chore: bump up canbench version to 0.1.8 chore: bump up canbench version Dec 9, 2024
@maksymar maksymar changed the title chore: bump up canbench version chore: bump up canbench to 0.1.4 Dec 9, 2024
@maksymar maksymar changed the title chore: bump up canbench to 0.1.4 chore: bump up canbench to 0.1.8 Dec 9, 2024
@maksymar maksymar marked this pull request as ready for review December 9, 2024 15:01
@maksymar maksymar requested a review from a team as a code owner December 9, 2024 15:01
@maksymar maksymar merged commit 64ea87a into master Dec 10, 2024
28 checks passed
@maksymar maksymar deleted the maksym/canbench branch December 10, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants