Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: canbench can run in dependabot PRs (part 1) #289

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

ielashi
Copy link
Collaborator

@ielashi ielashi commented Apr 8, 2024

CI for dependabot PRs like #288 are failing because canbench doesn't have the right permissions set up to post a comment with the benchmarking results.

This PR, and a follow-up one, will update CI to fix those permissions as we had done in the stable-structures and canbench repos.

@ielashi ielashi requested a review from a team as a code owner April 8, 2024 13:09
Copy link

github-actions bot commented Apr 8, 2024

canbench 🏋

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.77 M (-0.00%) (change within noise threshold)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.00 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (-0.00%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (-0.00%) (change within noise threshold)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@maksymar maksymar merged commit d467183 into master Apr 12, 2024
25 checks passed
@maksymar maksymar deleted the ielashi/fix_canbench_1 branch April 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants