Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (EXC-1590): make burning cycles configurable #286

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

ielashi
Copy link
Collaborator

@ielashi ielashi commented Apr 3, 2024

Problem

The latest version of the Bitcoin canister automatically burns all cycles it receives. DFX is unable to upgrade to that version since deploying it on a local app subnet immediately results in it being uninstalled.

Solution

Make burning cycles configurable, such that DFX can disable it when deploying the Bitcoin canister locally.

ielashi added 2 commits April 3, 2024 11:07
# Problem
The latest version of the Bitcoin canister automatically burns all
cycles it receives. DFX is unable to upgrade to that version since
deploying it on a local app subnet immediately results in it being
uninstalled.

# Solution

Make burning cycles configurable, such that DFX can disable it when
deploying the Bitcoin canister locally.
@ielashi ielashi requested a review from a team as a code owner April 3, 2024 09:08
@ielashi ielashi changed the title feat (EXC-1590): make burning cycles configurable fix (EXC-1590): make burning cycles configurable Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

canbench 🏋

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.77 M (-0.00%) (change within noise threshold)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.00 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (-0.00%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (-0.00%) (change within noise threshold)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@ielashi ielashi force-pushed the ielashi/config_burn_cycles branch from bc1b015 to a6ab71f Compare April 3, 2024 11:38
@ielashi ielashi enabled auto-merge (squash) April 3, 2024 12:47
@ielashi ielashi merged commit 567acfc into master Apr 3, 2024
25 checks passed
@ielashi ielashi deleted the ielashi/config_burn_cycles branch April 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants