feat: Make cargo bench part of CI to ensure we don’t accidentally introduce performance regressions #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure-we-dont-accidentally-introduce-performance-regressions_2
…sure-we-dont-accidentally-introduce-performance-regressions_2
…sure-we-dont-accidentally-introduce-performance-regressions_2
dsarlis
approved these changes
Oct 13, 2023
ielashi
requested changes
Oct 13, 2023
dragoljub-duric
commented
Oct 13, 2023
ielashi
reviewed
Oct 13, 2023
…sure-we-dont-accidentally-introduce-performance-regressions_2
…sure-we-dont-accidentally-introduce-performance-regressions_2
ielashi
reviewed
Oct 20, 2023
ielashi
reviewed
Oct 20, 2023
ielashi
reviewed
Oct 23, 2023
ielashi
reviewed
Oct 24, 2023
Co-authored-by: Islam El-Ashi <[email protected]>
ielashi
reviewed
Oct 24, 2023
ielashi
approved these changes
Oct 26, 2023
| chmod +x drun | ||
| } | ||
|
|
||
| get_correct_drun_release() { |
There was a problem hiding this comment.
nit:
Suggested change
| get_correct_drun_release() { | |
| maybe_download_drun() { |
dragoljub-duric
deleted the
EXC-1449-make-cargo-bench-part-of-ci-to-ensure-we-dont-accidentally-introduce-performance-regressions_2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We are not checking if new PRs are introducing performance regressions.
Solution:
Add benchmark test to CI.