Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix watchdog upgradability test in CI #256

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Oct 4, 2023

Download the latest watchdog canister wasm by traversing releases in reversed order.

In the past, the latest release included files for all related canisters, including the watchdog canister. However, there has been a recent change where releases for the Bitcoin canister are separated from others. As a result, the latest release may not always contain the watchdog canister's wasm file. This change caused the watchdog upgradability test to fail since it only checked the latest release page.

Now, the watchdog upgradability test goes through all releases in reverse order until it finds the watchdog canister wasm, ensuring the test's success.

@maksymar maksymar changed the title chore: fix upgradability test in CI chore: fix watchdog upgradability test in CI Oct 4, 2023
@maksymar maksymar marked this pull request as ready for review October 4, 2023 14:33
@maksymar maksymar requested a review from a team as a code owner October 4, 2023 14:33
Copy link
Collaborator

@ielashi ielashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maksymar!

@maksymar maksymar merged commit b2c50f5 into master Oct 4, 2023
20 of 21 checks passed
@maksymar maksymar deleted the maksym/fix-upgradability-test branch October 4, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants