Make cargo bench part of CI to ensure we don’t accidentally introduce performance regressions #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specification mentions that the fee percentiles are measured in [millisatoshi/vbyte](https://github.com/dfinity/interface-spec/blob/master/spec/index.md#ic-method-bitcoin_get_current_fee_percentiles-ic-bitcoin_get_current_fee_percentiles). This PR updates the code in accordance with the specification.
Bumps [rustls-webpki](https://github.com/rustls/webpki) from 0.100.1 to 0.100.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rustls/webpki/releases">rustls-webpki's releases</a>.</em></p> <blockquote> <h2>v/0.100.2</h2> <h2>Release notes</h2> <ul> <li>certificate path building and verification is now capped at 100 signature validation operations to avoid the risk of CPU usage denial-of-service attack when validating crafted certificate chains producing quadratic runtime. This risk affected both clients, as well as servers that verified client certificates.</li> </ul> <h2>What's Changed</h2> <ul> <li>v0.100.2 prep by <a href="https://github.com/cpu"><code>@cpu</code></a> in <a href="https://redirect.github.com/rustls/webpki/pull/154">rustls/webpki#154</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/rustls/webpki/compare/v/0.100.1...v/0.100.2">https://github.com/rustls/webpki/compare/v/0.100.1...v/0.100.2</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rustls/webpki/commit/c8b821450be5659be75c2a8ba663fc9fb0f8726c"><code>c8b8214</code></a> Bump MSRV to 1.60</li> <li><a href="https://github.com/rustls/webpki/commit/855752292e97c1caada65e7b53ecc5df010ea88a"><code>8557522</code></a> Avoid testing MSRV of dev-dependencies</li> <li><a href="https://github.com/rustls/webpki/commit/73a7f0c7d7eaaea038d2a1a48c18c47bcb487cc4"><code>73a7f0c</code></a> Cargo: version 0.100.1 -> 0.100.2</li> <li><a href="https://github.com/rustls/webpki/commit/4ea052366f342a06344aab589565179b59b342d3"><code>4ea0523</code></a> verify_cert: enforce maximum number of signatures.</li> <li>See full diff in <a href="https://github.com/rustls/webpki/compare/v/0.100.1...v/0.100.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/dfinity/bitcoin-canister/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Problem: The passing of watchdog_upgradability is not checked in check_pass on GitHub CI
Co-authored-by: Thomas Locher <[email protected]>
Problem: Replicated calls to query methods first go through consensus and then are rejected by the Bitcoin canister, hence wasting resources. Solution: Add inspect_message endpoint, which will reject all calls to the query endpoints. --------- Co-authored-by: Islam El-Ashi <[email protected]>
dragoljub-duric
force-pushed
the
EXC-1449-make-cargo-bench-part-of-ci-to-ensure-we-dont-accidentally-introduce-performance-regressions
branch
from
d8a6c9c to
5c0b8fa
Compare
…sure-we-dont-accidentally-introduce-performance-regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.