Skip to content

Commit

Permalink
chore: bump up canbench to 0.1.8 (#347)
Browse files Browse the repository at this point in the history
This PR upgrades `canbench` crate to v.0.1.8 and `pocket-ic` to 6.0.0.

Canbench tests for this PR showed a regression for
`pre_upgrade_with_many_unstable_blocks`, but that is expected since in
`canbench` v.0.1.5 there was a fix for correctly accounting the
instructions when writing stable memory
([release](https://github.com/dfinity/canbench/releases/tag/v0.1.5)),
which is exactly what is happening in bitcoin canister pre_upgrade.
  • Loading branch information
maksymar authored Dec 10, 2024
1 parent f7afb9d commit 64ea87a
Show file tree
Hide file tree
Showing 5 changed files with 142 additions and 66 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: CI
env:
RUST_VERSION: 1.76.0
DFX_VERSION: 0.21.0
POCKET_IC_SERVER_VERSION: 7.0.0

on:
push:
Expand Down Expand Up @@ -70,7 +71,7 @@ jobs:
- name: Install PocketIC (mac)
if: runner.os == 'macOS'
run: |
wget https://github.com/dfinity/pocketic/releases/download/5.0.0/pocket-ic-x86_64-darwin.gz
wget https://github.com/dfinity/pocketic/releases/download/$POCKET_IC_SERVER_VERSION/pocket-ic-x86_64-darwin.gz
gzip -d pocket-ic-x86_64-darwin.gz
mv pocket-ic-x86_64-darwin pocket-ic
chmod +x pocket-ic
Expand All @@ -79,7 +80,7 @@ jobs:
- name: Install PocketIC (linux)
if: runner.os == 'Linux'
run: |
wget https://github.com/dfinity/pocketic/releases/download/5.0.0/pocket-ic-x86_64-linux.gz
wget https://github.com/dfinity/pocketic/releases/download/$POCKET_IC_SERVER_VERSION/pocket-ic-x86_64-linux.gz
gzip -d pocket-ic-x86_64-linux.gz
mv pocket-ic-x86_64-linux pocket-ic
chmod +x pocket-ic
Expand Down
179 changes: 127 additions & 52 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ resolver = "2"
assert_matches = "1.5.0"
bitcoin = "0.28.1"
byteorder = "1.4.3"
canbench-rs = { version = "0.1.1" }
canbench-rs = "0.1.8"
candid = "0.10.6"
candid_parser = { version = "0.1.4" }
candid_parser = "0.1.4"
ciborium = "0.2.1"
clap = { version = "4.0.11", features = ["derive"] }
futures = "0.3.28"
Expand All @@ -47,7 +47,7 @@ ic-http = { path = "./ic-http" }
ic-metrics-encoder = "1.0.0"
ic-stable-structures = "0.6.7"
lazy_static = "1.4.0"
pocket-ic = "4.0.0"
pocket-ic = "6.0.0"
serde = "1.0.171"
serde_bytes = "0.11"
serde_json = "1.0.94"
Expand Down
Loading

0 comments on commit 64ea87a

Please sign in to comment.