Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back single command target #719

Open
HashimTheArab opened this issue Dec 22, 2022 · 2 comments
Open

Add back single command target #719

HashimTheArab opened this issue Dec 22, 2022 · 2 comments
Labels
discussion needed More discussion is needed to decide on this

Comments

@HashimTheArab
Copy link
Contributor

Many commands require a single target such as things like ban, setrank, mute, etc. Having to treat every command as multiple targets is very inconvenient, this was discussed before and I said I would add it but got busy

@Sandertv
Copy link
Member

I'm still not entirely convinced these "require" a single target

@Sandertv Sandertv added the discussion needed More discussion is needed to decide on this label Dec 23, 2022
@JustTalDevelops
Copy link
Member

JustTalDevelops commented Jan 5, 2023

I feel like this should be readded also.

I think, while it is easy to 'reproduce' single target functionality yourself, it creates quite a lot of duplicate and unnecessary code over a lot of commands versus having some sort of built-in type to handle them - for basically no cost on our part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed More discussion is needed to decide on this
Projects
None yet
Development

No branches or pull requests

3 participants