Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail silently when phlow.token is missing #305

Open
praqma-thi opened this issue Feb 16, 2018 · 3 comments
Open

Don't fail silently when phlow.token is missing #305

praqma-thi opened this issue Feb 16, 2018 · 3 comments

Comments

@praqma-thi
Copy link
Contributor

I just went through the git phlow with Johan, but struggled a bit at the start.
It silently failed whenever we wanted to interact with issues, but --verbose helped.
The phlow.token wasn't configured, (nor was GHI installed, but I don't know if that's still a requirement).

It could be nice to get an error message on that, though.

@buep
Copy link
Contributor

buep commented Feb 18, 2018

Your console log output would be nice, I'm not fully sure how to reproduce.

But never the less, I think it makes sense to make this issue about never failing silent at all. Every time we can't recover from a problem or fail automatically, we should explain to the user what went wrong and fail with a noticeable error message.

@buep buep added this to the Backlog milestone Feb 18, 2018
@praqma-thi
Copy link
Contributor Author

Console log was on Johan V.'s machine. He uses a Mac.
Maybe I can get him to remove the plow.token and run some more commands again.
I'll set up a reminder, maybe snag him on a Friday.

@buep
Copy link
Contributor

buep commented Feb 22, 2018

No worries, we would have to reproduce in a test anyway... so just if some more information about reproducing would also be fine.

And as mentioned, this issues should be about not failing silently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants