Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp version upgrade #141

Closed
ArynRama opened this issue Feb 13, 2024 · 3 comments · Fixed by #149
Closed

aiohttp version upgrade #141

ArynRama opened this issue Feb 13, 2024 · 3 comments · Fixed by #149

Comments

@ArynRama
Copy link

Summary

when trying to install lavalink.py it tries to install a version of aiohttp which is unsupported by python 3.12

Lavalink & System Version

OS: Windows
Python version: 3.12
Lavalink.py: 5.1.0

Reproduction

run pip install lavalink

@devoxin
Copy link
Owner

devoxin commented Feb 13, 2024

The current state of affairs with aiohttp 3.9 is that I would sacrifice support for Python versions below 3.8. If I bump it now, I would need to slate it for a lavalink.py v6 release due to its breaking nature. For the time being, you can work around this by doing pip install lavalink --no-dependencies. Lavalink.py doesn't need any dependencies other than aiohttp anyway, so as long as you have the desired version of aiohttp installed, the library will just use that.

I shall keep this issue opened until a solution is pushed to the master branch, however there may not be any updates to this issue until a 6.0 release is ready, but with 5.0 still being relatively new, this may be a ways off.

@BazZziliuS
Copy link

You can make a beta release without aiohttp or with an updated one because poetry does not allow you to install without dependencies

@zlalvani
Copy link

This also prevents compatibility with other libraries (e.g. hikari) whose latest versions require a newer aiohttp version (>=3.9).

FWIW Python3.7 reached EOL in 2023 and 3.8 will later this year so it's not unreasonable to drop support.

@devoxin devoxin linked a pull request Jul 23, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants